Fix for SourceComments including stdin instead of proper file path #286
+71
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry for the wait, could you add a test that was previously failing for that to the testsuite? |
|
Yes, please add a test for this. I'm also concerned that passing the |
|
With the fix in #314, this is now failing. Can you please update? |
xzyfer
force-pushed
the
master
branch
13 times, most recently
from
5c3ead2
to
cc4ed2f
Compare
|
@xzyfer are you still interested in this? I rebased it, but unsure if you want to land it: master...XhmikosR:pr/286 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #234